Skip to content

bpo-41756: Delete PyGen_Send function#22663

Merged
1st1 merged 1 commit intopython:masterfrom
vladima:delete_pygen_send
Oct 12, 2020
Merged

bpo-41756: Delete PyGen_Send function#22663
1st1 merged 1 commit intopython:masterfrom
vladima:delete_pygen_send

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Oct 12, 2020

Delete PyGen_Send function and inline its body into PyIter_Send. This PR does not introduce new functionality so there is nothing to report in news.

https://bugs.python.org/issue41756

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

Comment thread Objects/genobject.c

PySendResult
PyGen_Send(PyGenObject *gen, PyObject *arg, PyObject **result)
PyIter_Send(PyObject *iter, PyObject *arg, PyObject **result)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, what function does the ceval look call now when in tracing?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It calls _PyObject_CallMethodIdOneArg(receiver, &PyId_send, v).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@1st1 1st1 added the skip news label Oct 12, 2020
@1st1 1st1 merged commit 24a54c0 into python:master Oct 12, 2020
@bedevere-bot
Copy link
Copy Markdown

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@1st1
Copy link
Copy Markdown
Member

1st1 commented Oct 12, 2020

Thanks @vladima and @serhiy-storchaka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants